[JENKINS-71337] Fix configuration not being saved. #16
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not 100% sure what caused it but appears to have been added when config was converted from being global. Updating to more recent conventions appears to have fixed it (ex: setting variables through constructor). Also had to add inline to config for the sub-boolean option.
Testing done
Testing updating configs from existing values, adding new config on initial setup, and that setting via the config.xml directly still parsed correctly.
Submitter checklist